fix: Failing to delete multiple chat history together bug#956
Merged
Conversation
refactor: dev to main - Foundry Roles and sanitize CU output for Unicode integrity
refactor: dev to main - Improve search index deletion logic and handling
chore: dev to main merge
Ashwal-Microsoft
requested review from
Avijit-Microsoft,
Roopan-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
nchandhi and
toherman-msft
as code owners
Ashwal-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the frontend chat history APIs to better support paginated history listing and to make “clear all history” more resilient when a bulk-delete endpoint is unavailable.
Changes:
- Added a
limitparameter tohistoryListand sends it to/history/listfor paginated fetching. - Enhanced
historyDeleteAllto attempt bulk deletion first, and fall back to paginated listing + per-conversation deletion when the bulk route returns404.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Roopan-Microsoft
approved these changes
Jun 10, 2026
Contributor
|
🎉 This PR is included in version 3.23.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and flexibility of the chat history deletion logic, especially for deployments that do not support bulk deletion. The main changes include adding pagination support to the history listing API and enhancing the "delete all history" function to fall back to deleting conversations individually if the bulk API is unavailable.
History listing improvements:
limitparameter to thehistoryListAPI, allowing you to specify how many conversations to fetch per page. This enables paginated fetching of conversation history.History deletion enhancements:
historyDeleteAllfunction to:limitparameter and delete them individually.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information